Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node20 for GitHub action #29

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

cgrothaus
Copy link
Collaborator

@cgrothaus cgrothaus commented Aug 27, 2024

Ziel

Node v16 für Github Actions ist deprecated, wir müssen Node v20 nehmen. Siehe:

Zudem müssen folgende Actions aktualisiert werden, u.a. um Node v20 zu bekommen:

  • actions/chekcout@v3 -> actions/checkout@v4
  • actions/cache@v3 -> actions/cache@v4
  • docker/setup-buildx-action@v2 -> docker/setup-buildx-action@v3
  • docker/build-push-action@v3 -> docker/build-push-action@v6

Änderungen

  • Use Node v20 for GitHub Action
  • Upgrade Github Actions versions of actions/checkout, actions/cache, docker/setup-buildx-action, docker/build-push-action:
  • Upgrade versions in test workflow
  • Prepare for release of tag v4 (in uses declarations)

Hinweise

  • Dieser PR ist nicht getestet, da der Test-Workflow in meinem Fork-Repo nicht läuft.
  • Dieser PR kann gut Commit für Commit reviewed werden.
  • Dieser PR bereitet Actions Code und Doku (hoffentlich korrekt) auf ein Release @v4 vor

@cgrothaus cgrothaus self-assigned this Aug 27, 2024
…ocker/setup-buildx-action, docker/build-push-action:

- actions/chekcout@v3 -> actions/checkout@v4
- actions/cache@v3 -> actions/cache@v4
- docker/setup-buildx-action@v2 -> docker/setup-buildx-action@v3
- docker/build-push-action@v3 -> docker/build-push-action@v6
@cgrothaus cgrothaus force-pushed the use-node20-for-github-action branch from 8df841a to 250d147 Compare August 27, 2024 12:47
@cgrothaus cgrothaus requested a review from kevinkupski August 27, 2024 12:50
@stefanvocke
Copy link
Contributor

@cgrothaus sieht für mich soweit gut aus 👍
Die Tests failen wohl aufgrund von Berechtigungsproblemen. Das fixe ich ggf. noch in einem seperaten PR.

@stefanvocke stefanvocke merged commit 406d584 into setopsco:main Aug 30, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants